fix(NODE-6399): support new options arguments #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
W-A-James
changed the title
aditi-khare-mongoDB
requested changes
Sep 26, 2024
|
Can we align with: #45 This was the highlight there and we published it as a fix, we are not updating the type definitions here so mongodb-legacy users "can't" use these new option objects. Internal MongoDB Driver fixNote A correction has been made to an API that is only relevant to driver internals. There are no public-facing API changes in this fix. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
nbbeeken
requested changes
Sep 26, 2024
W-A-James
changed the title
nbbeeken
approved these changes
Sep 27, 2024
aditi-khare-mongoDB
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Added support for optional options argument in certain GridFSBucket methods and ChangeStream.close
Is there new documentation needed for these changes?
No
What is the motivation for this change?
NODE-6399
Release Highlight
Internal MongoDB Driver fix
Note
A correction has been made to an API that is only relevant to driver internals. There are no public-facing API changes in this fix.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript